• mmn's avatar
    added missing return statement after showForm call · ea837cea
    mmn authored
    Issue #3125 at http://status.net/open-source/issues/3125 (and its duplicate 3127) describe buggy behaviour when trying to create a new group - i.e. the group is still created but with nickname NULL.
    
    The reason the group is created is that when failing Nickname::normalize, the function trySave() in actions/newgroup.php doesn't call 'return' - meaning it just keeps going despite the error thrown. It a
    
    So the simple solution to this bug was adding a return call at line 128, inside the catch just after the showForm(...) call.
    ea837cea
Name
Last commit
Last update
..
accessadminpanel.php Loading commit data...
addpeopletag.php Loading commit data...
all.php Loading commit data...
allrss.php Loading commit data...
apiaccountratelimitstatus.php Loading commit data...
apiaccountupdatedeliverydevice.php Loading commit data...
apiaccountupdateprofile.php Loading commit data...
apiaccountupdateprofileimage.php Loading commit data...
apiaccountverifycredentials.php Loading commit data...
apiatomservice.php Loading commit data...
apiblockcreate.php Loading commit data...
apiblockdestroy.php Loading commit data...
apiconversation.php Loading commit data...
apidirectmessage.php Loading commit data...
apidirectmessagenew.php Loading commit data...
apifavoritecreate.php Loading commit data...
apifavoritedestroy.php Loading commit data...
apifriendshipscreate.php Loading commit data...
apifriendshipsdestroy.php Loading commit data...
apifriendshipsexists.php Loading commit data...
apifriendshipsshow.php Loading commit data...
apigroupcreate.php Loading commit data...
apigroupismember.php Loading commit data...
apigroupjoin.php Loading commit data...
apigroupleave.php Loading commit data...
apigrouplist.php Loading commit data...
apigrouplistall.php Loading commit data...
apigroupmembership.php Loading commit data...
apigroupprofileupdate.php Loading commit data...
apigroupshow.php Loading commit data...
apihelptest.php Loading commit data...
apilist.php Loading commit data...
apilistmember.php Loading commit data...
apilistmembers.php Loading commit data...
apilistmemberships.php Loading commit data...
apilists.php Loading commit data...
apilistsubscriber.php Loading commit data...
apilistsubscribers.php Loading commit data...
apilistsubscriptions.php Loading commit data...
apimediaupload.php Loading commit data...
apioauthaccesstoken.php Loading commit data...
apioauthauthorize.php Loading commit data...
apioauthpin.php Loading commit data...
apioauthrequesttoken.php Loading commit data...
apisearchatom.php Loading commit data...
apisearchjson.php Loading commit data...
apistatusesdestroy.php Loading commit data...
apistatusesretweet.php Loading commit data...
apistatusesretweets.php Loading commit data...
apistatusesshow.php Loading commit data...
apistatusesupdate.php Loading commit data...
apistatusnetconfig.php Loading commit data...
apistatusnetversion.php Loading commit data...
apisubscriptions.php Loading commit data...
apitimelinefavorites.php Loading commit data...
apitimelinefriends.php Loading commit data...
apitimelinegroup.php Loading commit data...
apitimelinehome.php Loading commit data...
apitimelinelist.php Loading commit data...
apitimelinementions.php Loading commit data...
apitimelinepublic.php Loading commit data...
apitimelineretweetedbyme.php Loading commit data...
apitimelineretweetedtome.php Loading commit data...
apitimelineretweetsofme.php Loading commit data...
apitimelinetag.php Loading commit data...
apitimelineuser.php Loading commit data...
apitrends.php Loading commit data...
apiuserfollowers.php Loading commit data...
apiuserfriends.php Loading commit data...
apiuserprofileimage.php Loading commit data...
apiusershow.php Loading commit data...
approvegroup.php Loading commit data...
approvesub.php Loading commit data...
atompubfavoritefeed.php Loading commit data...
atompubmembershipfeed.php Loading commit data...
atompubshowfavorite.php Loading commit data...
atompubshowmembership.php Loading commit data...
atompubshowsubscription.php Loading commit data...
atompubsubscriptionfeed.php Loading commit data...
attachment.php Loading commit data...
attachment_ajax.php Loading commit data...
attachment_thumbnail.php Loading commit data...
avatarbynickname.php Loading commit data...
avatarsettings.php Loading commit data...
backupaccount.php Loading commit data...
block.php Loading commit data...
blockedfromgroup.php Loading commit data...
bookmarklet.php Loading commit data...
cancelgroup.php Loading commit data...
cancelsubscription.php Loading commit data...
confirmaddress.php Loading commit data...
conversation.php Loading commit data...
conversationreplies.php Loading commit data...
deleteaccount.php Loading commit data...
deleteapplication.php Loading commit data...
deletegroup.php Loading commit data...
deletenotice.php Loading commit data...
deleteuser.php Loading commit data...
disfavor.php Loading commit data...
doc.php Loading commit data...
editapplication.php Loading commit data...
editgroup.php Loading commit data...
editpeopletag.php Loading commit data...
emailsettings.php Loading commit data...
favor.php Loading commit data...
favorited.php Loading commit data...
favoritesrss.php Loading commit data...
featured.php Loading commit data...
file.php Loading commit data...
foaf.php Loading commit data...
foafgroup.php Loading commit data...
geocode.php Loading commit data...
getfile.php Loading commit data...
grantrole.php Loading commit data...
groupblock.php Loading commit data...
groupbyid.php Loading commit data...
grouplogo.php Loading commit data...
groupmembers.php Loading commit data...
groupqueue.php Loading commit data...
grouprss.php Loading commit data...
groups.php Loading commit data...
groupsearch.php Loading commit data...
groupunblock.php Loading commit data...
hostmeta.php Loading commit data...
imsettings.php Loading commit data...
inbox.php Loading commit data...
invite.php Loading commit data...
joingroup.php Loading commit data...
leavegroup.php Loading commit data...
licenseadminpanel.php Loading commit data...
login.php Loading commit data...
logout.php Loading commit data...
makeadmin.php Loading commit data...
microsummary.php Loading commit data...
newapplication.php Loading commit data...
newgroup.php Loading commit data...
newmessage.php Loading commit data...
newnotice.php Loading commit data...
noticesearch.php Loading commit data...
noticesearchrss.php Loading commit data...
nudge.php Loading commit data...
oauthappssettings.php Loading commit data...
oauthconnectionssettings.php Loading commit data...
oembed.php Loading commit data...
oldschoolsettings.php Loading commit data...
opensearch.php Loading commit data...
otp.php Loading commit data...
outbox.php Loading commit data...
passwordsettings.php Loading commit data...
pathsadminpanel.php Loading commit data...
peoplesearch.php Loading commit data...
peopletag.php Loading commit data...
peopletagautocomplete.php Loading commit data...
peopletagged.php Loading commit data...
peopletagsbyuser.php Loading commit data...
peopletagsforuser.php Loading commit data...
peopletagsubscribers.php Loading commit data...
peopletagsubscriptions.php Loading commit data...
plugindisable.php Loading commit data...
pluginenable.php Loading commit data...
pluginsadminpanel.php Loading commit data...
profilecompletion.php Loading commit data...
profilesettings.php Loading commit data...
profiletagbyid.php Loading commit data...
public.php Loading commit data...
publicrss.php Loading commit data...
publictagcloud.php Loading commit data...
publicxrds.php Loading commit data...
recoverpassword.php Loading commit data...
redirect.php Loading commit data...
redirecturl.php Loading commit data...
register.php Loading commit data...
removepeopletag.php Loading commit data...
repeat.php Loading commit data...
replies.php Loading commit data...
repliesrss.php Loading commit data...
restoreaccount.php Loading commit data...
revokerole.php Loading commit data...
robotstxt.php Loading commit data...
rsd.php Loading commit data...
sandbox.php Loading commit data...
selftag.php Loading commit data...
sessionsadminpanel.php Loading commit data...
showapplication.php Loading commit data...
showfavorites.php Loading commit data...
showgroup.php Loading commit data...
showmessage.php Loading commit data...
shownotice.php Loading commit data...
showprofiletag.php Loading commit data...
showstream.php Loading commit data...
silence.php Loading commit data...
siteadminpanel.php Loading commit data...
sitenoticeadminpanel.php Loading commit data...
smssettings.php Loading commit data...
snapshotadminpanel.php Loading commit data...
subedit.php Loading commit data...
subqueue.php Loading commit data...
subscribe.php Loading commit data...
subscribepeopletag.php Loading commit data...
subscribers.php Loading commit data...
subscriptions.php Loading commit data...
sup.php Loading commit data...
tag.php Loading commit data...
tagprofile.php Loading commit data...
tagrss.php Loading commit data...
top.php Loading commit data...
unblock.php Loading commit data...
unsandbox.php Loading commit data...
unsilence.php Loading commit data...
unsubscribe.php Loading commit data...
unsubscribepeopletag.php Loading commit data...
urlsettings.php Loading commit data...
useradminpanel.php Loading commit data...
userbyid.php Loading commit data...
usergroups.php Loading commit data...
userrss.php Loading commit data...
userxrd.php Loading commit data...
version.php Loading commit data...