1. 28 Jan, 2011 1 commit
  2. 24 Jan, 2011 2 commits
    • Brion Vibber's avatar
      Fix XML API output for several profile update methods that returned a <user>... · 0a3c05fe
      Brion Vibber authored
      Fix XML API output for several profile update methods that returned a <user> entry but didn't set namespaces, causing XML parse failures.
      0a3c05fe
    • Brion Vibber's avatar
      Fix for ticket #3007: .bmp avatar uploads weren't being properly converted to PNG in all cases · 820dd293
      Brion Vibber authored
      Part of the reported issue was previuosly fixed by dc497ed0 (smaller size images being blanked).
      This commit fixes the remaining bug with original-size avatars being left as BMP (which could include the 96px size for instance, which could cause problems in browsers not supporting BMP natively)
      
      Added ImageFile::copyTo() as a convenient alias for resizeTo() when not resizing; this performs the BMP/XPM/XBM->PNG conversion if needed, or copies the original file.
      Copying instead of using move_uploaded_file() is fine here since:
      a) the files are cleaned up on script completion anyway (vs moving to remove it)
      b) we're already performing getimagesize() and possibly load/resize on the file before this point (vs needing to move the file into a usable area to work with open_basedir restrictions that prevent working directly with uploaded files in the temp dir; since this would fail anyway, we lose nothing)
      
      ImageFile::preferredType() now works on $this->type instead of asking for one, to make it handier to use from outside. (This is still needed in order for calling code to generate a target filename.)
      
      Recommended for future:
      * additional consolidation between the various ways of uploading avatars (touched avatarsettings, grouplogo, and apiaccountupdateprofileimage with similar minor changes)
      * consolidate type checks and file naming into Avatar class
      820dd293
  3. 21 Jan, 2011 5 commits
  4. 20 Jan, 2011 7 commits
  5. 19 Jan, 2011 2 commits
  6. 17 Jan, 2011 2 commits
  7. 14 Jan, 2011 3 commits
  8. 08 Jan, 2011 1 commit
  9. 07 Jan, 2011 1 commit
    • Brion Vibber's avatar
      Fix warning in subscribers/subscriptions list pages where we attempted to call... · 5616bfb5
      Brion Vibber authored
      Fix warning in subscribers/subscriptions list pages where we attempted to call free() an ArrayWrapper after it was used up, thus trying to forward the call to a nonexistent object.
      
      Removed the free calls (unneeded since destructors now work), and added an error check w/ logging & an exception for future attempts to forward calls to nonexistent object.
      5616bfb5
  10. 06 Jan, 2011 2 commits
  11. 29 Dec, 2010 1 commit
  12. 28 Dec, 2010 3 commits
  13. 27 Dec, 2010 1 commit
  14. 22 Dec, 2010 3 commits
  15. 18 Dec, 2010 2 commits
  16. 17 Dec, 2010 1 commit
  17. 15 Dec, 2010 2 commits
  18. 14 Dec, 2010 1 commit