1. 14 Jan, 2016 1 commit
  2. 27 Feb, 2015 1 commit
    • mmn's avatar
      StatusNet class renamed GNUsocial · 8fac7a9f
      mmn authored
      also added backward compatible StatusNet class for the two calls I know
      third party plugins use, isHTTPS and getActivePlugins
      8fac7a9f
  3. 28 Oct, 2013 1 commit
  4. 18 Aug, 2013 1 commit
    • mmn's avatar
      The overloaded DB_DataObject function staticGet is now called getKV · 2a4dc77a
      mmn authored
      I used this hacky sed-command (run it from your GNU Social root, or change the first grep's path to where it actually lies) to do a rough fix on all ::staticGet calls and rename them to ::getKV
      
         sed -i -s -e '/DataObject::staticGet/I!s/::staticGet/::getKV/Ig' $(grep -R ::staticGet `pwd`/* | grep -v -e '^extlib' | grep -v DataObject:: |grep -v "function staticGet"|cut -d: -f1 |sort |uniq)
      
      If you're applying this, remember to change the Managed_DataObject and Memcached_DataObject function definitions of staticGet to getKV!
      
      This might of course take some getting used to, or modification fo StatusNet plugins, but the result is that all the static calls (to staticGet) are now properly made without breaking PHP Strict Standards. Standards are there to be followed (and they caused some very bad confusion when used with get_called_class)
      
      Reasonably any plugin or code that tests for the definition of 'GNUSOCIAL' or similar will take this change into consideration.
      2a4dc77a
  5. 18 Apr, 2011 2 commits
  6. 06 Sep, 2010 1 commit
  7. 11 Aug, 2010 1 commit
  8. 04 Jun, 2010 1 commit
  9. 21 May, 2010 1 commit
  10. 29 Mar, 2010 2 commits
  11. 18 Feb, 2010 1 commit
    • Brion Vibber's avatar
      Queues: redid the breakout control model so we can start up and subscribe to... · ce6be4f8
      Brion Vibber authored
      Queues: redid the breakout control model so we can start up and subscribe to queues without running through the complete site list, which is ok at 1k sites but too slow at 10k.
      All breakout queues that we're going to need to listen to now need to be explicitly listed in $config['queue']['breakout'].
      
      Until XMPP is moved to component model, this setting will let the individual processes work with their own queues:
      $config['queue']['breakout'][] = 'xmpp/xmppout/' . $config['site']['nickname'];
      ce6be4f8
  12. 16 Feb, 2010 2 commits
    • Brion Vibber's avatar
      Stomp queue restructuring for mass scalability: · c74aea58
      Brion Vibber authored
      - Multiplexing queues into groups and for multiple sites.
      - Sharing vs breakout configurable per site and per queue via $config['queue']['breakout']
      - Detect how many times a message is redelivered, discard if it's killed too many daemons
       - count configurable with $config['queue']['max_retries']
       - can dump the items to files in $config['queue']['dead_letter_dir']
      
      Queue daemon memory & resource leak fixes:
      - avoid unnecessary reconnections to memcached server (switch persistent connections back in on second initialization, assuming it's child process)
      - monkey-patch for leaky .ini loads in DB_DataObject::databaseStructure() - was leaking 200k per active switch
      - applied leak fixes to Status_network as well, using intermediate base Safe_DataObject for both it and Memcache_DataObject
      
      Misc queue fixes:
      - correct handling of child processes exiting due to signal termination instead of regular exit
      - shutdown instead of infinite respawn loop if we're already past the soft memory limit at startup
      - Added --all option for xmppdaemon... still opens one xmpp connection per site that has xmpp active
      
      Cache updates:
      - add Cache::increment() method with native support for memcached atomic increment
      c74aea58
    • Brion Vibber's avatar
  13. 10 Feb, 2010 2 commits
  14. 30 Jan, 2010 1 commit
  15. 29 Jan, 2010 1 commit
    • Brion Vibber's avatar
      Manual failover for stomp queues. · 155a5d44
      Brion Vibber authored
      If an array of multiple servers is put in $config['queue']['stomp_server'], enqueues will pick a random server to send to (failing over automatically if any are down).
      Queue handling daemons connect all servers so they get events no matter where they were delivered.
      In case of disconnection, daemons should now handle it gracefully and attempt to reconnect every 60 seconds or so, automatically resubscribing to all queues once it's back up.
      
      Can put to 'native' failover for reads as well by disabling $config['stomp']['manual_failover'] = false; but this is untested and may explode in addition to requiring that your ActiveMQ cluster actually be set up to handle its own data distribution.
      
      Additionally, can choose which queues to mark as persistent by setting $config['stomp']['persistent'] to an array of queue names.
      155a5d44
  16. 28 Jan, 2010 2 commits
  17. 27 Jan, 2010 1 commit
  18. 26 Jan, 2010 1 commit
    • Brion Vibber's avatar
      Control channel for queue daemons to request graceful shutdown, restart, or... · 58be61b6
      Brion Vibber authored
      Control channel for queue daemons to request graceful shutdown, restart, or update to listen to a newly added or reconfigured site.
      
        queuectl.php --update -s<site>
        queuectl.php --stop
        queuectl.php --restart
      
      Default control channel is /topic/statusnet-control. For external utilities to send a site update ping direct to the queue server, connect via Stomp and send a message formatted thus:
      
        update:<nickname>
      
      (Nickname here, *not* server hostname! The rest of the queues will be updated to use nicknames later.)
      
      Note that all currently-connected queue daemons will get these notifications, including both queuedaemon.php and xmppdaemon.php. (XMPP will ignore site update requests for sites that it's not handling.)
      
      Limitations:
      * only implemented for stomp queue manager so far
      * --update may not yet handle a changed server name properly
      * --restart won't reload PHP code files that were already loaded at startup. Still need to stop and restart the daemons from 'outside' when updating code base.
      58be61b6
  19. 22 Jan, 2010 7 commits
    • Craig Andrews's avatar
      845f051c
    • Craig Andrews's avatar
      Will re-enable anything queueing after 0.9.x merge · 78eb9c78
      Craig Andrews authored
      Revert "Any object (not just Notice's) can be queued"
      
      This reverts commit 77ea02ca.
      78eb9c78
    • Brion Vibber's avatar
      Fix for stuck queue messages: wrap processing in stomp transactions so our... · 6e4cad71
      Brion Vibber authored
      Fix for stuck queue messages: wrap processing in stomp transactions so our lack of an ACK if PHP dies actually triggers redelivery.
      
      Previously, messages once delivered would just get stuck in the queue seemingly forever if they never got ACKed.
      Note this could lead to partial duplication, for instance if the OMB or Twitter queue handlers die after 1/2 of the outgoing sends.
      
      Recommendations:
      * catch exceptions more aggressively within queue handlers (so only PHP fatal errors are likely to kill in the middle)
      * for processing that involves sending to multiple clients, consider a second queue similar to the XMPP output, eg for OMB:
       - first queue gets delivery list and builds message data, enqueueing it for each target address
       - second queue can handle each individual outgoing message (and attempt redelivery etc separately)
      
      This would also protect better against a recurring error preventing delivery in the second part, and could spread out any slow sends over multiple threads.
      6e4cad71
    • Brion Vibber's avatar
      XMPP queued output & initial retooling of DB queue manager to support non-Notice objects. · c7507e7e
      Brion Vibber authored
      Queue handlers for XMPP individual & firehose output now send their XML stanzas
      to another output queue instead of connecting directly to the chat server. This
      lets us have as many general processing threads as we need, while all actual
      XMPP input and output go through a single daemon with a single connection open.
      
      This avoids problems with multiple connected resources:
      * multiple windows shown in some chat clients (psi, gajim, kopete)
      * extra load on server
      * incoming message delivery forwarding issues
      
      Database changes:
      * queue_item drops 'notice_id' in favor of a 'frame' blob.
        This is based on Craig Andrews' work branch to generalize queues to take any
        object, but conservatively leaving out the serialization for now.
        Table updater (preserves any existing queued items) in db/rc3to09.sql
      
      Code changes to watch out for:
      * Queue handlers should now define a handle() method instead of handle_notice()
      * QueueDaemon and XmppDaemon now share common i/o (IoMaster) and respawning
        thread management (RespawningDaemon) infrastructure.
      * The polling XmppConfirmManager has been dropped, as the message is queued
        directly when saving IM settings.
      * Enable $config['queue']['debug_memory'] to output current memory usage at
        each run through the event loop to watch for memory leaks
      
      To do:
      * Adapt XMPP i/o to component connection mode for multi-site support.
      * XMPP input can also be broken out to a queue, which would allow the actual
        notice save etc to be handled by general queue threads.
      * Make sure there are no problems with simply pushing serialized Notice objects
        to queues.
      * Find a way to improve interactive performance of the database-backed queue
        handler; polling is pretty painful to XMPP.
      * Possibly redo the way QueueHandlers are injected into a QueueManager. The
        grouping used to split out the XMPP output queue is a bit awkward.
      
      Conflicts:
      
      	scripts/xmppdaemon.php
      c7507e7e
    • Brion Vibber's avatar
      Fix for stuck queue messages: wrap processing in stomp transactions so our... · 99866a45
      Brion Vibber authored
      Fix for stuck queue messages: wrap processing in stomp transactions so our lack of an ACK if PHP dies actually triggers redelivery.
      
      Previously, messages once delivered would just get stuck in the queue seemingly forever if they never got ACKed.
      Note this could lead to partial duplication, for instance if the OMB or Twitter queue handlers die after 1/2 of the outgoing sends.
      
      Recommendations:
      * catch exceptions more aggressively within queue handlers (so only PHP fatal errors are likely to kill in the middle)
      * for processing that involves sending to multiple clients, consider a second queue similar to the XMPP output, eg for OMB:
       - first queue gets delivery list and builds message data, enqueueing it for each target address
       - second queue can handle each individual outgoing message (and attempt redelivery etc separately)
      
      This would also protect better against a recurring error preventing delivery in the second part, and could spread out any slow sends over multiple threads.
      99866a45
    • Brion Vibber's avatar
      XMPP queued output & initial retooling of DB queue manager to support non-Notice objects. · 0e852def
      Brion Vibber authored
      Queue handlers for XMPP individual & firehose output now send their XML stanzas
      to another output queue instead of connecting directly to the chat server. This
      lets us have as many general processing threads as we need, while all actual
      XMPP input and output go through a single daemon with a single connection open.
      
      This avoids problems with multiple connected resources:
      * multiple windows shown in some chat clients (psi, gajim, kopete)
      * extra load on server
      * incoming message delivery forwarding issues
      
      Database changes:
      * queue_item drops 'notice_id' in favor of a 'frame' blob.
        This is based on Craig Andrews' work branch to generalize queues to take any
        object, but conservatively leaving out the serialization for now.
        Table updater (preserves any existing queued items) in db/rc3to09.sql
      
      Code changes to watch out for:
      * Queue handlers should now define a handle() method instead of handle_notice()
      * QueueDaemon and XmppDaemon now share common i/o (IoMaster) and respawning
        thread management (RespawningDaemon) infrastructure.
      * The polling XmppConfirmManager has been dropped, as the message is queued
        directly when saving IM settings.
      * Enable $config['queue']['debug_memory'] to output current memory usage at
        each run through the event loop to watch for memory leaks
      
      To do:
      * Adapt XMPP i/o to component connection mode for multi-site support.
      * XMPP input can also be broken out to a queue, which would allow the actual
        notice save etc to be handled by general queue threads.
      * Make sure there are no problems with simply pushing serialized Notice objects
        to queues.
      * Find a way to improve interactive performance of the database-backed queue
        handler; polling is pretty painful to XMPP.
      * Possibly redo the way QueueHandlers are injected into a QueueManager. The
        grouping used to split out the XMPP output queue is a bit awkward.
      0e852def
    • Brion Vibber's avatar
      XMPP queued output & initial retooling of DB queue manager to support non-Notice objects. · 26fdf0c9
      Brion Vibber authored
      Queue handlers for XMPP individual & firehose output now send their XML stanzas
      to another output queue instead of connecting directly to the chat server. This
      lets us have as many general processing threads as we need, while all actual
      XMPP input and output go through a single daemon with a single connection open.
      
      This avoids problems with multiple connected resources:
      * multiple windows shown in some chat clients (psi, gajim, kopete)
      * extra load on server
      * incoming message delivery forwarding issues
      
      Database changes:
      * queue_item drops 'notice_id' in favor of a 'frame' blob.
        This is based on Craig Andrews' work branch to generalize queues to take any
        object, but conservatively leaving out the serialization for now.
        Table updater (preserves any existing queued items) in db/rc3to09.sql
      
      Code changes to watch out for:
      * Queue handlers should now define a handle() method instead of handle_notice()
      * QueueDaemon and XmppDaemon now share common i/o (IoMaster) and respawning
        thread management (RespawningDaemon) infrastructure.
      * The polling XmppConfirmManager has been dropped, as the message is queued
        directly when saving IM settings.
      * Enable $config['queue']['debug_memory'] to output current memory usage at
        each run through the event loop to watch for memory leaks
      
      To do:
      * Adapt XMPP i/o to component connection mode for multi-site support.
      * XMPP input can also be broken out to a queue, which would allow the actual
        notice save etc to be handled by general queue threads.
      * Make sure there are no problems with simply pushing serialized Notice objects
        to queues.
      * Find a way to improve interactive performance of the database-backed queue
        handler; polling is pretty painful to XMPP.
      * Possibly redo the way QueueHandlers are injected into a QueueManager. The
        grouping used to split out the XMPP output queue is a bit awkward.
      26fdf0c9
  20. 21 Jan, 2010 1 commit
  21. 15 Jan, 2010 1 commit
  22. 14 Jan, 2010 2 commits
  23. 13 Jan, 2010 1 commit
    • Brion Vibber's avatar
      Major refactoring of queue handlers to support running multiple sites in one daemon. · ec145b73
      Brion Vibber authored
      Key changes:
      * Initialization code moved from common.php to StatusNet class;
        can now switch configurations during runtime.
      * As a consequence, configuration files must now be idempotent...
        Be careful with constant, function or class definitions.
      * Control structure for daemons/QueueManager/QueueHandler has been refactored;
        the run loop is now managed by IoMaster run via scripts/queuedaemon.php
        IoManager subclasses are woken to handle socket input or polling, and may
        cover multiple sites.
      * Plugins can implement notice queue handlers more easily by registering a
        QueueHandler class; no more need to add a daemon.
      
      The new QueueDaemon runs from scripts/queuedaemon.php:
      
      * This replaces most of the old *handler.php scripts; they've been refactored
        to the bare handler classes.
      * Spawns multiple child processes to spread load; defaults to CPU count on
        Linux and Mac OS X systems, or override with --threads=N
      * When multithreaded, child processes are automatically respawned on failure.
      * Threads gracefully shut down and restart when passing a soft memory limit
        (defaults to 90% of memory_limit), limiting damage from memory leaks.
      * Support for UDP-based monitoring: http://www.gitorious.org/snqmon
      
      Rough control flow diagram:
      QueueDaemon -> IoMaster -> IoManager
                                 QueueManager [listen or poll] -> QueueHandler
                                 XmppManager [ping & keepalive]
                                 XmppConfirmManager [poll updates]
      
      Todo:
      
      * Respawning features not currently available running single-threaded.
      * When running single-site, configuration changes aren't picked up.
      * New sites or config changes affecting queue subscriptions are not yet
        handled without a daemon restart.
      * SNMP monitoring output to integrate with general tools (nagios, ganglia)
      * Convert XMPP confirmation message sends to use stomp queue instead of polling
      * Convert xmppdaemon.php to IoManager?
      * Convert Twitter status, friends import polling daemons to IoManager
      * Clean up some error reporting and failure modes
      * May need to adjust queue priorities for best perf in backlog/flood cases
      
      Detailed code history available in my daemon-work branch:
      http://www.gitorious.org/~brion/statusnet/brion-fixes/commits/daemon-work
      ec145b73
  24. 15 Sep, 2009 1 commit
  25. 12 Sep, 2009 1 commit
    • Marcel van der Boom's avatar
      Several fixes to make RabbitMQ a player. · c0498701
      Marcel van der Boom authored
        * extlib/Stomp.php
          -spaces for tabs (we're on PEAR, right?)
          - send: initialize the $properties parameter as array() instead of null
            this prevents unsetting $headers if $properties was not set
            (besides that, it's the proper way to initialize an array)
          - subscribe: insert FIXME's on ActiveMQ specifics
          - ack: make sure the content-length header is set *and* is zero.
            I have seen the header set to '3' there but could not find where it
            came from, this is at least safe.
          - disconnect: typo in $headers variable
          - readFrame: use fgets() instead of gets() so that RabbitQ, which is more protocol strict can also play
        * extlib/Stomp/Frame.php
          - spaces for tabs
          - add note on possibly protocol violating linefeed
        * extlib/Stomp/Message.php
          - space for tabs
          - add content-length header for message
        * lib/stompqueuemanager.php
          - use the notice for logging, not the frame
      c0498701
  26. 25 Aug, 2009 3 commits