git.gnu.io has moved to IP address 209.51.188.249 -- please double check where you are logging in.

Commit ea837cea authored by mmn's avatar mmn

added missing return statement after showForm call

Issue #3125 at http://status.net/open-source/issues/3125 (and its duplicate 3127) describe buggy behaviour when trying to create a new group - i.e. the group is still created but with nickname NULL.

The reason the group is created is that when failing Nickname::normalize, the function trySave() in actions/newgroup.php doesn't call 'return' - meaning it just keeps going despite the error thrown. It a

So the simple solution to this bug was adding a return call at line 128, inside the catch just after the showForm(...) call.
parent 3ad3535c
......@@ -125,6 +125,7 @@ class NewgroupAction extends Action
$nickname = Nickname::normalize($this->trimmed('newnickname'));
} catch (NicknameException $e) {
$this->showForm($e->getMessage());
return;
}
$fullname = $this->trimmed('fullname');
$homepage = $this->trimmed('homepage');
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment