Commit 053e9973 authored by Evan Prodromou's avatar Evan Prodromou

add rel=nofollow to bookmark links if needed

parent e64ae1f0
......@@ -62,38 +62,37 @@ class BookmarkListItem extends NoticeListItemAdapter
$nb = Bookmark::getByNotice($notice);
$profile = $notice->getProfile();
if (empty($nb)) {
common_log(LOG_ERR, "No bookmark for notice {$notice->id}");
parent::showContent();
return;
} else if (empty($nb->url)) {
common_log(LOG_ERR, "No url for bookmark {$nb->id} for notice {$notice->id}");
parent::showContent();
return;
}
$atts = $notice->attachments();
$profile = $notice->getProfile();
if (empty($atts)) {
$out->elementStart('p', array('class' => 'entry-content'));
// Something went wrong!
// Whether to nofollow
common_log(
LOG_ERR,
sprintf(
'Bookmark %1$s (notice %2$d) has no attachments.',
$nb->id,
$notice->id
)
);
$attrs = array('href' => $nb->url,
'class' => 'bookmark-title');
// try to show the notice as plain text
$nf = common_config('nofollow', 'external');
parent::showContent();
return;
if ($nf == 'never' || ($nf == 'sometimes' and $out instanceof ShowstreamAction)) {
$attrs['rel'] = 'external';
} else {
$attrs['rel'] = 'nofollow external';
}
$out->elementStart('p', array('class' => 'entry-content'));
$att = $atts[0];
$out->elementStart('h3');
$out->element('a',
array('href' => $att->url,
'class' => 'bookmark-title'),
$nb->title);
$attrs,
$nb->title);
$out->elementEnd('h3');
// Replies look like "for:" tags
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment