GitHost.io will be shut down on June 1, 2019. At that point this instance will be unreachable and all data will be irrevocably deleted. More details at https://about.gitlab.com/gitlab-hosted/#githost-is-shutting-down-on-june-1st-2019

  • Brion Vibber's avatar
    XMPP queued output & initial retooling of DB queue manager to support non-Notice objects. · c7507e7e
    Brion Vibber authored
    Queue handlers for XMPP individual & firehose output now send their XML stanzas
    to another output queue instead of connecting directly to the chat server. This
    lets us have as many general processing threads as we need, while all actual
    XMPP input and output go through a single daemon with a single connection open.
    
    This avoids problems with multiple connected resources:
    * multiple windows shown in some chat clients (psi, gajim, kopete)
    * extra load on server
    * incoming message delivery forwarding issues
    
    Database changes:
    * queue_item drops 'notice_id' in favor of a 'frame' blob.
      This is based on Craig Andrews' work branch to generalize queues to take any
      object, but conservatively leaving out the serialization for now.
      Table updater (preserves any existing queued items) in db/rc3to09.sql
    
    Code changes to watch out for:
    * Queue handlers should now define a handle() method instead of handle_notice()
    * QueueDaemon and XmppDaemon now share common i/o (IoMaster) and respawning
      thread management (RespawningDaemon) infrastructure.
    * The polling XmppConfirmManager has been dropped, as the message is queued
      directly when saving IM settings.
    * Enable $config['queue']['debug_memory'] to output current memory usage at
      each run through the event loop to watch for memory leaks
    
    To do:
    * Adapt XMPP i/o to component connection mode for multi-site support.
    * XMPP input can also be broken out to a queue, which would allow the actual
      notice save etc to be handled by general queue threads.
    * Make sure there are no problems with simply pushing serialized Notice objects
      to queues.
    * Find a way to improve interactive performance of the database-backed queue
      handler; polling is pretty painful to XMPP.
    * Possibly redo the way QueueHandlers are injected into a QueueManager. The
      grouping used to split out the XMPP output queue is a bit awkward.
    
    Conflicts:
    
    	scripts/xmppdaemon.php
    c7507e7e
smsqueuehandler.php 1.16 KB