We are no longer offering accounts on this server. Consider https://gitlab.freedesktop.org/ as a place to host projects.

  1. 15 Jan, 2011 1 commit
  2. 14 Jan, 2011 11 commits
  3. 10 Jan, 2011 1 commit
  4. 08 Jan, 2011 3 commits
  5. 07 Jan, 2011 2 commits
  6. 06 Jan, 2011 1 commit
  7. 05 Jan, 2011 5 commits
  8. 04 Jan, 2011 5 commits
  9. 03 Jan, 2011 3 commits
  10. 31 Dec, 2010 8 commits
    • Brion Vibber's avatar
      Bookmark plugin: tweak post-upload success message to distinguish between... · ae59046b
      Brion Vibber authored
      Bookmark plugin: tweak post-upload success message to distinguish between "already done" (UnQueueManager) and "started, should finish eventually" (other queue manager)
      ae59046b
    • Brion Vibber's avatar
      Bookmark plugin: fix for delicious import with queues enabled · 3368c33b
      Brion Vibber authored
      We were passing DOM nodes directly into the queues for the final bookmark import stage; unfortunately these don't actually survive serialization.
      Moved the extraction of properties from the HTML up to the first-stage handler, so now we don't have to worry about moving DOM nodes from one handler to the next. Instead passing an associative array of properties, which is fed into the Bookmark::saveNew by the per-bookmark handler.
      3368c33b
    • Brion Vibber's avatar
      Bookmark plugin: fixes for bad DOM element nesting in delicious import data · fedfde9b
      Brion Vibber authored
      delicious bookmark exports use the godawful HTML bookmark file format that ancient versions of Netscape used (and has thus been the common import/export format for bookmarks since the dark ages of the web :)
      This arranges bookmark entries as an HTML definition list, using a lot of implied close tags (leaving off the </dt> and </dd>).
      DOMDocument->loadHTML() uses libxml2's HTML mode, which generally does ok with muddling through things but apparently is really, really bad about handling those implied close tags.
      
      Sequences of adjacent <dt> elements (eg bookmark without a description, followed by another bookmark "<dt><dt>"), end up interpreted as nested ("<dt><dt></dt></dt>") instead of as siblings ("<dt></dt><dt></dt>").
      The first round of code tried to resolve the nesting inline, but ended up a bit funky in places.
      I've replaced this with a standalone run through the data to re-order the elements, based on our knowing that <dt> and <dd> cannot directly contain one another; once that's done, our main logic loop can be a bit cleaner. I'm not 100% sure it's doing nested sublists correctly, but these don't seem to show up in delicious export (and even if they do, with the way we flatten the input it shouldn't make a difference).
      
      Also fixed a clearer edge case where some bookmarks didn't get imported when missing descriptions.
      fedfde9b
    • Brion Vibber's avatar
      Bookmark plugin: graceful error out for failure to import a delicious bookmark... · 56875318
      Brion Vibber authored
      Bookmark plugin: graceful error out for failure to import a delicious bookmark due to it being already bookmarked
      56875318
    • Brion Vibber's avatar
      Fix up edge case in nickname processing: overlong display forms should be... · 80e2f4f5
      Brion Vibber authored
      Fix up edge case in nickname processing: overlong display forms should be rejected before normalization (storage of display forms will also have fields with limited length)
      80e2f4f5
    • Evan Prodromou's avatar
      5dfc9e1b
    • Evan Prodromou's avatar
      66f6b2a3
    • Evan Prodromou's avatar