- 28 Feb, 2011 3 commits
-
-
Brion Vibber authored
-
Brion Vibber authored
-
Brion Vibber authored
fix - Notice: Undefined variable: action in /Library/WebServer/Documents/mublog/lib/action.php on line 521
-
- 23 Jan, 2011 6 commits
-
-
Evan Prodromou authored
-
Evan Prodromou authored
-
Evan Prodromou authored
-
Evan Prodromou authored
There's a new menu layout in this version of the software. It was implemented as a plugin in 0.9.x to avoid clashes with existing themes, but we're going to break that compatibility in this version, so we're just going for it. This change involved moving all the changes in NewMenuPlugin into the default code that was calling it. In addition, since accountsettingsaction and connectsettingsaction differed only by menu, I removed them, changed all references to them to the settingsmenu, and moved the combined nav to its own class. Let's put that episode behind us. The CSS shim that was loaded by NewMenuPlugin for certain themes and certain actions was removed.
-
Evan Prodromou authored
-
Evan Prodromou authored
'admin' is a pretty common username that people try when installing; it was blacklisted because all of our admin panels were at /admin/*, which would conflict with the admin user's namespace. Changed the location of all admin panels to /panel/*, blacklisted the nickname 'panel', and allowed 'admin'. Tested with a fresh install; seems to work great.
-
- 14 Jan, 2011 3 commits
-
-
Evan Prodromou authored
-
Evan Prodromou authored
-
Evan Prodromou authored
-
- 12 Jan, 2011 2 commits
-
-
Evan Prodromou authored
-
Evan Prodromou authored
Conflicts: README
-
- 10 Jan, 2011 1 commit
-
-
Evan Prodromou authored
-
- 08 Jan, 2011 3 commits
-
-
Evan Prodromou authored
-
Evan Prodromou authored
-
Evan Prodromou authored
-
- 07 Jan, 2011 2 commits
-
-
Evan Prodromou authored
-
Evan Prodromou authored
-
- 06 Jan, 2011 1 commit
-
-
Zach Copley authored
-
- 05 Jan, 2011 5 commits
-
-
Zach Copley authored
-
Evan Prodromou authored
-
Craig Andrews authored
-
Brion Vibber authored
Added json2.min.js to the makefile so it can be updated easily when json2.js changes.
-
Evan Prodromou authored
-
- 04 Jan, 2011 5 commits
-
-
Evan Prodromou authored
-
Brion Vibber authored
It seems to have actually been saving correctly, but the update of the colors on the form success page wasn't working properly. When a design object is pulled out of the database, the numeric fields are read in as strings, so black comes back as "0". But, when we populate the new object and then stick it live, we've populated it with actual integers; with memcache on these might live for a while in the cache... The fallback code in Design::toWebColor() did a check ($color == null) which would be false for the string "0", but counts as true for the *integer* 0. Thus, the display code would initially interpret the correctly-saved black color as "use default". Changing the check to === against null and "" empty string avoids the false positive on integers, and lets us see our nice black text immediately after save.
-
Brion Vibber authored
-
Brion Vibber authored
The $base_url var is never defined, and the code has actually always been wrong since it was added. Just removing it seems to work fine :)
-
-
- 03 Jan, 2011 3 commits
-
-
Evan Prodromou authored
-
Evan Prodromou authored
This reverts commit 3d62c1cf.
-
Evan Prodromou authored
We can make a lot of HTTP requests from the server side. This change adds some configuration options for using an HTTP proxy, which can cache hits from multiple sites (good for status.net-like services, for example).
-
- 31 Dec, 2010 6 commits
-
-
Brion Vibber authored
Bookmark plugin: tweak post-upload success message to distinguish between "already done" (UnQueueManager) and "started, should finish eventually" (other queue manager)
-
Brion Vibber authored
We were passing DOM nodes directly into the queues for the final bookmark import stage; unfortunately these don't actually survive serialization. Moved the extraction of properties from the HTML up to the first-stage handler, so now we don't have to worry about moving DOM nodes from one handler to the next. Instead passing an associative array of properties, which is fed into the Bookmark::saveNew by the per-bookmark handler.
-
Brion Vibber authored
delicious bookmark exports use the godawful HTML bookmark file format that ancient versions of Netscape used (and has thus been the common import/export format for bookmarks since the dark ages of the web :) This arranges bookmark entries as an HTML definition list, using a lot of implied close tags (leaving off the </dt> and </dd>). DOMDocument->loadHTML() uses libxml2's HTML mode, which generally does ok with muddling through things but apparently is really, really bad about handling those implied close tags. Sequences of adjacent <dt> elements (eg bookmark without a description, followed by another bookmark "<dt><dt>"), end up interpreted as nested ("<dt><dt></dt></dt>") instead of as siblings ("<dt></dt><dt></dt>"). The first round of code tried to resolve the nesting inline, but ended up a bit funky in places. I've replaced this with a standalone run through the data to re-order the elements, based on our knowing that <dt> and <dd> cannot directly contain one another; once that's done, our main logic loop can be a bit cleaner. I'm not 100% sure it's doing nested sublists correctly, but these don't seem to show up in delicious export (and even if they do, with the way we flatten the input it shouldn't make a difference). Also fixed a clearer edge case where some bookmarks didn't get imported when missing descriptions.
-
Brion Vibber authored
Bookmark plugin: graceful error out for failure to import a delicious bookmark due to it being already bookmarked
-
Brion Vibber authored
Fix up edge case in nickname processing: overlong display forms should be rejected before normalization (storage of display forms will also have fields with limited length)
-
Evan Prodromou authored
-