- 25 May, 2010 1 commit
-
-
Brion Vibber authored
Hotpatch for infinite redirection-following loop seen processing URLs to http://clojure.org/ -- if we end up with an unstable redirect target (final item in a redirect chain ends up redirecting us somewhere else when we visit it again), just save the last version we saw instead of trying to start over. Pretty much everything in File and File_redirection initial processing needs to be rewritten to be non-awful; this code is very hard to follow and very easy to make huge bugs. A fair amount of the complication is probably obsoleted by the redirection following being built into HTTPClient now.
-
- 23 May, 2010 1 commit
-
-
Brion Vibber authored
Hotpatch for Facebook mirror problems: drop messages when hitting rate limit (err 341) instead of retrying forever. On unknown errors, now throwing an exception so it'll hit the message retry limits.
-
- 21 May, 2010 5 commits
-
-
Brion Vibber authored
-
Brion Vibber authored
Must be set to a value that matches one of the entries in $config['queue']['stomp_server'] array, otherwise ignored.
-
Zach Copley authored
-
Brion Vibber authored
-
Brion Vibber authored
Disable SSL peer/hostname verification for HTTPClient unless we've configured a trusted CA bundle like this: $config['http']['ssl_cafile'] = '/usr/lib/ssl/certs/ca-certificates.crt'; The previous state was failing on all HTTPS hits due to HTTP_Request2 library turning on the validation check but not specifying a CA file.
-
- 20 May, 2010 1 commit
-
-
Brion Vibber authored
Added block link to subscription notification emails; block action can now take a profile ID on the URL; added profile details to block page so there's an indication of who you're blocking before you pull the trigger. Fixed typo in RedirectingAction when no return-to data provided in form submission. RedirectingAction::returnToArgs() has been renamed to returnToPrevious() to avoid conflict with Action::returnToArgs() which returns arguments to be passed to other actions as return-to arguments. All callers should now be updated. More profile settings actions will now redirect through a login form if visited as a GET request, as would be expected from a bookmark, link sent in e-mail etc.
-
- 19 May, 2010 5 commits
-
-
Brion Vibber authored
Quick fix for creating OpenID accounts authenticating against a MediaWiki site; trim the 'User:' etc from the final path segment before generating a nickname from it. Avoids ending up with nicks like 'userbrion' on your first OpenID login!
-
Brion Vibber authored
-
Brion Vibber authored
Add config option for RequireValidatedEmail plugin to skip the check for folks with a trusted OpenID association. Also added an event that other plugins or local config can use to override the checks.
-
Zach Copley authored
facebook posting code.
-
Brion Vibber authored
Locale switch cleanup: use common_switch_locale() which is safer for updating gettext state. Also moved a few calls to reduce chance of hitting an exception before switching back. Should help with problems where xmppdaemon would get stuck in wrong locale.
-
- 18 May, 2010 10 commits
-
-
Zach Copley authored
-
Zach Copley authored
-
Zach Copley authored
-
Zach Copley authored
attribution - Remove stray break statement from NoticeList
-
Zach Copley authored
-
Zach Copley authored
-
Zach Copley authored
-
Zach Copley authored
-
Brion Vibber authored
Redirect non-SSL hits to login & register actions to SSL if 'always' or 'sometimes' SSL modes are kicked in. The forms would already submit to SSL, but people are happier if they start on a secure page! Note: this really should be done for sensitive/all URLs in index.php, but it seems a bit awkward to reconstruct the SSL version of the link atm. Cleanup todo!
-
Brion Vibber authored
-
- 17 May, 2010 2 commits
-
-
Brion Vibber authored
-
Brion Vibber authored
Previously was using the reply-to URL, which didn't match with other displays. Now sends to the right conversation page.
-
- 14 May, 2010 2 commits
-
-
James Walker authored
-
James Walker authored
-
- 13 May, 2010 1 commit
-
-
Brion Vibber authored
-
- 12 May, 2010 1 commit
-
-
Brion Vibber authored
-
- 11 May, 2010 2 commits
-
-
Brion Vibber authored
-
Brion Vibber authored
Added a comment that the writable directory checks are insufficient to catch ACL problems on Windows; need a better check for that.
-
- 08 May, 2010 1 commit
-
-
Zach Copley authored
-
- 07 May, 2010 1 commit
-
-
Brion Vibber authored
-
- 06 May, 2010 1 commit
-
-
Brion Vibber authored
One-line addition of 'webos' to the keywords list.
-
- 05 May, 2010 6 commits
-
-
Zach Copley authored
-
Brion Vibber authored
-
Brion Vibber authored
Quick fix for DirectionDetector: only apply <span class="rtl"> once; if it's already there in an incoming message (eg via OStatus), don't reapply it. Modified from patch from Everplays
-
Brion Vibber authored
-
Brion Vibber authored
Added a 2-second default timeout for XMLRPC/extended pings, configurable as [ping,timeout]. No longer repeating the entire ping section if we had an HTTP error during a submission. For now, dropping the bad item and continuing on with others. (Todo: individual retry and cleaner discards of blacklisted broken-for-now sites.)
-
Brion Vibber authored
The code pattern 'new XXXException($e)' to chain exceptions doesn't actually work as intended, as exceptions are actually expecting a string message here. This caused an implicit string conversion from HTTP_Request2_Exception, which is a PEAR_Exception, which defines an absurdly detailed __toString() method including a giant HTML table with a backtrace if you happen to be on a web request. Simply passing $e->getMessage() instead clears this up, as we'll get the nice short message like 'Couldn't connect to tcp://blahblah:80'
-