1. 09 Sep, 2013 2 commits
    • mmn's avatar
      Tidying up getUser calls to profiles and some events · 747fe9d5
      mmn authored
      getUser calls are much more strict, and one place where this was found was
      in the (un)subscribe start/end event handlers, which resulted in making the
      Subscription class a bit stricter, regarding ::start and ::cancel at least.
      Several minor fixes in many files were made due to this.
      
      This does NOT touch the Foreign_link function, which should also have a more
      strict getUser call. That is a future project.
      747fe9d5
    • mmn's avatar
      Using a bit more of $this->scoped (Action parent class) · c5bf6cb0
      mmn authored
      $this->scoped is the currently active profile, which is intended
      to replace the $user object in the long run...
      c5bf6cb0
  2. 02 Sep, 2013 4 commits
    • mmn's avatar
      NewapplicationAction converted to FormAction · b2a0aa20
      mmn authored
      Cutting down on a bunch of redundant code. We're reusing a lot of stuff
      from FormAction and Action now instead of having copies of code all over.
      b2a0aa20
    • mmn's avatar
      needLogin renamed checkLogin and made a property · f0e967fe
      mmn authored
      Action extended classes now can set 'needLogin' as a protected property,
      which is defaulted to 'false'. However, FormAction defaults this to 'true'
      because most of the form actions will require a current login to be valid.
      
      NewgroupAction, NewmessageAction, NewnoticeAction are all affected by this
      commit and in the future we will migrate each potential formaction to the
      proper class parent tree. :)
      f0e967fe
    • mmn's avatar
      newmessage (and Message class) fixed for FormAction · e5e3aeb4
      mmn authored
      Also added a needLogin function to the Action class, which will do
      redirect to login page with proper returnto setting.
      e5e3aeb4
    • mmn's avatar
      IMPORTANT: parent::handlePost() in NewnoticeAction · 89b10666
      mmn authored
      otherwise we don't do csrf checking etc...
      89b10666
  3. 01 Sep, 2013 3 commits
    • mmn's avatar
      NewnoticeAction converted to extend FormAction · 0612e5ec
      mmn authored
      There are still several improvements which can be made, such as not
      having an entirely separate setup of ajax form functions. Instead
      those should be implemented in FormAction. But at least now we got
      rid of the redundant code use in prepare/handle.
      0612e5ec
    • mmn's avatar
      Conforming to code layout · c735a836
      mmn authored
      c735a836
    • mmn's avatar
      Proper definition of $args array in NewgroupAction->prepare · 83000f6f
      mmn authored
      Also, there is no need to do 'return' after throwing a ClientError
      Exception. And we'll use the Action->clientError for logging benefits
      until the error handling is properly done all the way to backend.
      83000f6f
  4. 31 Aug, 2013 1 commit
    • mmn's avatar
      NewgroupAction converted to extend FormAction · cfa699e4
      mmn authored
      Had to change Action function 'prepare' to 'protected', as you can't
      (of course) protect something that's been public in a parent class. The
      other way around seems fine for PHP... Eventually all actions will have
      protected 'prepare' (use execute/run)
      
      A feature of the previously fixed initialization of Action classes, is
      that we now have $this->scoped which is the current profile in use. As
      of now that is always a local User, except the corresponding Profile
      object.
      
      Also, instead of calling 'showForm' everywhere, in case of an error we
      just throw an exception of some sort and pass the message along there.
      
      I've also introduced in FormAction the 'showInstructions' function in
      order to get a unified instructions/info/error display method.
      
      TODO: Improve info/error message handling, and what/when/where to show.
      cfa699e4
  5. 30 Aug, 2013 1 commit
    • mmn's avatar
      Added a FormAction extension · 8d57fb7d
      mmn authored
      FormAction will act as a parent class to Action classes that use forms
      of various sorts, such as newgroup creation, settings actions etc.
      8d57fb7d
  6. 29 Aug, 2013 9 commits
  7. 28 Aug, 2013 3 commits
  8. 21 Aug, 2013 5 commits
    • mmn's avatar
      Woops, forgot auto_increment (comes with 'serial') · 40fe10e0
      mmn authored
      There are still some classes not ported (like Yammer import)
      40fe10e0
    • mmn's avatar
      GNU Social extensions fixes (please read note) · 4fab7a9d
      mmn authored
      These extensions are not considered secure nor stable right now, so don't
      use them for a while.
      4fab7a9d
    • mmn's avatar
      IMPORTANT - fixed HubSub to properly fetch primary keys · 0bbcfa7b
      mmn authored
      In commit e95f77d3 HubSub lost the
      'staticGet' function in a consolidation into the Managed_DataObject class.
      This was done carelessly by me as HubSub::staticGet was actually taking
      two arguments, none of which was a key and merging them in HubSub::hashkey()
      (staticGet was renamed getKV 2a4dc77a).
      
      NOTE: This complements commit 7e4718a4 which
      fixed a similar issue for the Magicsig class.
      0bbcfa7b
    • mmn's avatar
      OStatus classes now has modern schemaDef · 66997f2b
      mmn authored
      66997f2b
    • mmn's avatar
      IMPORTANT: Making prev. Memcached_DataObject working again with schemaDef · 3a7261f7
      mmn authored
      Lots of the Memcached_DataObject classes stopped working when upgraded to
      Managed_DataObject because they lacked schemaDef().
      
      I have _hopefully_ made it so that all the references to the table uses
      each class' schemaDef, rather than the more manual ColumnDef stuff. Not
      all plugins have been tested thoroughly yet.
      
      NOTE: This is applied with getKV calls instead of staticGet, as it was
      important for PHP Strict Standards compliance to avoid calling the non-
      static functions statically. (unfortunately DB and DB_DataObject still do
      this within themselves...)
      3a7261f7
  9. 20 Aug, 2013 2 commits
  10. 19 Aug, 2013 3 commits
  11. 18 Aug, 2013 7 commits