GitLab

We should probably get rid of this function, at least storing everything in
lib/mail.php - but until then, at least let's make it more understandable.

Release date: 2014-01-16 19:53 UTC

we know we have to get rid of PEAR::DB, but don't alarm users with hundreds
of lines of output.

Since we store 'favorite' verbs as notices now too, they caused a lot of
"null" notices that might not be interesting before we handle them better
in the UIs.

because otherwise pages which don't display the breaking <h1> element
(like showstream, i.e. your own profile for example) won't have clickable
entry forms.

it did in FreeSocial, where I copied my code from.

Getting rid of NoticeListItemAdapter, putting more into ActivityHandlerPlugin
and relying on plugins to handle rendering code of the content. This gives us
a lot more structure and consistency in notice structure and allows activity
plugins to stop rendering certain kinds of notices more easily.

There should also be a property for an ActivityHandlerPlugin class to avoid
rendering notices in the ordinary stream, so we don't have to overload stuff.

also removed some debugging lines

Now we have to get rid of OStatus dependency in lib/activityhandlerplugin.php

But it still doesn't quite work properly, so a lot of work is necessary for this.

Due to cache miss? Probably, but now we simply say that it's null in that case
so we get a proper exception from Notice::_setProfiles

Lost dependency of OStatus plugin for lib/microappplugin.php, whoo!

also noting which plugins should be upgraded to new saveActivity support.

Favorite plugin won't work with the new system just yet, it doesn't have
the necessary functions to extract activity objects, but that's coming
in the next (few) commits.

saveActivity will accept an Activity which gets parsed and saved through
plugins. So when an ActivityHandlerPlugin (such as Favorite will be soon)
gets a feed to save, this will be the function called instead of saveNew.

Also modified related classes to support this feature.

Dummy functions in Favorite plugin so far

Action now has 'isAction' which compares the loaded Action with names
of classes in an array (added without the 'Action') to its own type.