GitLab

This completes 1c6f9df8 where a lot
of other functions were fixed (by conforming to startHTML and endHTML)

Source: https://github.com/openid/php-openid

I had a problem with PHP5.5 that caused ajax responses to be empty. This
fixes it, as the problem was related to pretty inconsistent calling to
headers, XMLWriter::startDocument etc. etc.

mrvdb used '' rather than null for the padding argument. MMN-o changed that.

Apparently I forgot scripts/commandline.inc in the commit for 'GNUSOCIAL'
definition 4c6803a0.

define('GNUSOCIAL', true); indicates that we're running GNUSOCIAL, and that
one should be aware of this if applying patches.

Call needs 2nd parameter to be array.

Includes some minor changes to other things as well, such as the session
token input element now having the same 'name' attribute as everyone else.
(it still retains a 'token-'+noticeid 'id' attribute for clientside JS)

In 6de3fc02 bookmark.js was patched to
jquery 2.x (removed '.die' call) but unfortunately the 'submit' event
was attached to an input element instead of a form element (which got
a 'click' event).

New Exception class added (MethodNotImplementedException)

They were getting in the way of some strict-typing stuff.

This will return a proper DB_DataObject instance (as the desired class)
and not an array, or ArrayWrapper.

removed lib/subs.php as it was essentially only a wrapper for Subscription

Will have to change the 'maxnoticelength' code to stop shortening ALL
links if the setting for infinitely long notices is configured.

STATUSNET is still there for compatibility, so we don't have to change
all scripts at once yet...

No longer bundled with the library (as jquery-ui is bundled with the
main software, including the autocomplete part).

Rewrites had to be made to migrate, as several API things had changed
when jquery-ui took over the library.

Currently (like before, right?) this only autocompletes in the end of
the current textarea. So you can't jump back in the middle of a text
and autocomplete a user or group. This is a serious deficiency, though
not a regression.

Not only that one can often correlate email address md5 hash sums, but
the "functionality" depends on a bunch of external calls.

This is because it calls call_user_func_array with that exact $args argument.

Modified and additionally commented by MMN-o

cookieValue was matched against null, not undefined.

Also added to minification Makefile in js/ as it was not delivered from
upstream as .min.js

This won't run properly if other scripts stop javascript execution before
it's time to crop (such as in the Bookmark plugin, which when writing this
hasn't been migrated to Jquery 2.x - so it stops on a '.die' call).

Some images were cleaned up from the theme/base/images/illustrations too.

Source: https://github.com/instanceofme/jquery-infieldlabels/

It seems we don't need all the development files. Though it feels a bit
evil not to keep them. Then again we didn't have the whole dev-tree there.

Really we should maybe use git submodules for this?

I also made sure that if we don't have minify enabled, a non-minified
version of jquery-ui is loaded, as minification is the most evil of all.
Bad as hell to debug, and anyone visiting the site should be allowed to
view all scripts that are run in an overseeable manner.