1. 22 Jan, 2010 1 commit
    • Brion Vibber's avatar
      XMPP queued output & initial retooling of DB queue manager to support non-Notice objects. · 26fdf0c9
      Brion Vibber authored
      Queue handlers for XMPP individual & firehose output now send their XML stanzas
      to another output queue instead of connecting directly to the chat server. This
      lets us have as many general processing threads as we need, while all actual
      XMPP input and output go through a single daemon with a single connection open.
      This avoids problems with multiple connected resources:
      * multiple windows shown in some chat clients (psi, gajim, kopete)
      * extra load on server
      * incoming message delivery forwarding issues
      Database changes:
      * queue_item drops 'notice_id' in favor of a 'frame' blob.
        This is based on Craig Andrews' work branch to generalize queues to take any
        object, but conservatively leaving out the serialization for now.
        Table updater (preserves any existing queued items) in db/rc3to09.sql
      Code changes to watch out for:
      * Queue handlers should now define a handle() method instead of handle_notice()
      * QueueDaemon and XmppDaemon now share common i/o (IoMaster) and respawning
        thread management (RespawningDaemon) infrastructure.
      * The polling XmppConfirmManager has been dropped, as the message is queued
        directly when saving IM settings.
      * Enable $config['queue']['debug_memory'] to output current memory usage at
        each run through the event loop to watch for memory leaks
      To do:
      * Adapt XMPP i/o to component connection mode for multi-site support.
      * XMPP input can also be broken out to a queue, which would allow the actual
        notice save etc to be handled by general queue threads.
      * Make sure there are no problems with simply pushing serialized Notice objects
        to queues.
      * Find a way to improve interactive performance of the database-backed queue
        handler; polling is pretty painful to XMPP.
      * Possibly redo the way QueueHandlers are injected into a QueueManager. The
        grouping used to split out the XMPP output queue is a bit awkward.
  2. 13 Jan, 2010 1 commit
    • Brion Vibber's avatar
      Major refactoring of queue handlers to support running multiple sites in one daemon. · ec145b73
      Brion Vibber authored
      Key changes:
      * Initialization code moved from common.php to StatusNet class;
        can now switch configurations during runtime.
      * As a consequence, configuration files must now be idempotent...
        Be careful with constant, function or class definitions.
      * Control structure for daemons/QueueManager/QueueHandler has been refactored;
        the run loop is now managed by IoMaster run via scripts/queuedaemon.php
        IoManager subclasses are woken to handle socket input or polling, and may
        cover multiple sites.
      * Plugins can implement notice queue handlers more easily by registering a
        QueueHandler class; no more need to add a daemon.
      The new QueueDaemon runs from scripts/queuedaemon.php:
      * This replaces most of the old *handler.php scripts; they've been refactored
        to the bare handler classes.
      * Spawns multiple child processes to spread load; defaults to CPU count on
        Linux and Mac OS X systems, or override with --threads=N
      * When multithreaded, child processes are automatically respawned on failure.
      * Threads gracefully shut down and restart when passing a soft memory limit
        (defaults to 90% of memory_limit), limiting damage from memory leaks.
      * Support for UDP-based monitoring: http://www.gitorious.org/snqmon
      Rough control flow diagram:
      QueueDaemon -> IoMaster -> IoManager
                                 QueueManager [listen or poll] -> QueueHandler
                                 XmppManager [ping & keepalive]
                                 XmppConfirmManager [poll updates]
      * Respawning features not currently available running single-threaded.
      * When running single-site, configuration changes aren't picked up.
      * New sites or config changes affecting queue subscriptions are not yet
        handled without a daemon restart.
      * SNMP monitoring output to integrate with general tools (nagios, ganglia)
      * Convert XMPP confirmation message sends to use stomp queue instead of polling
      * Convert xmppdaemon.php to IoManager?
      * Convert Twitter status, friends import polling daemons to IoManager
      * Clean up some error reporting and failure modes
      * May need to adjust queue priorities for best perf in backlog/flood cases
      Detailed code history available in my daemon-work branch:
  3. 20 Nov, 2009 2 commits
  4. 21 Sep, 2009 1 commit
  5. 28 Aug, 2009 2 commits
  6. 26 Aug, 2009 1 commit
  7. 25 Aug, 2009 2 commits
  8. 22 Jun, 2009 2 commits
  9. 20 Jun, 2009 3 commits
  10. 12 Feb, 2009 1 commit
  11. 23 Dec, 2008 4 commits
    • Evan Prodromou's avatar
      move opening brace of class declaration to next line · b264c03d
      Evan Prodromou authored
      Another gigantor PEAR coding standards patch. Here, I've moved the
      opening curly bracket on a class statement to the following line.
    • Evan Prodromou's avatar
      change function headers to K&R style · 04ef1ba8
      Evan Prodromou authored
      Another huge change, for PEAR code standards compliance. Function
      headers have to be in K&R style (opening brace on its own line),
      instead of having the opening brace on the same line as the function
      and parameters. So, a little perl magic found all the function
      definitions and move the opening brace to the next line (properly
      indented... usually).
    • Evan Prodromou's avatar
      replace NULL with null · eb2f9c98
      Evan Prodromou authored
      Another global search-and-replace update. Here, I've replaced the PHP
      keyword 'NULL' with its lowercase version. This is another PEAR code
      standards change.
    • Evan Prodromou's avatar
      replace all tabs with four spaces · edbc0c66
      Evan Prodromou authored
      The PEAR coding standards decree: no tabs, but indent by four spaces.
      I've done a global search-and-replace on all tabs, replacing them by
      four spaces. This is a huge change, but it will go a long way to
      getting us towards phpcs-compliance. And that means better code
      readability, and that means more participation.
  12. 04 Sep, 2008 1 commit
  13. 31 Aug, 2008 2 commits
  14. 30 Aug, 2008 2 commits
  15. 28 Aug, 2008 3 commits
  16. 27 Aug, 2008 1 commit
    • Evan Prodromou's avatar
      break up monolithic xmppdaemon into multiple queue handlers · b9f0ea6f
      Evan Prodromou authored
      Eventually, the poor xmppdaemon has become overloaded with extra
      tasks. So, I've broken it up. Now, we have 5 background scripts, and
      more coming:
      * xmppdaemon.php - handles incoming XMPP messages only.
      * xmppqueuehandler.php - sends notices from the queue out through XMPP.
      * smsqueuehandler.php - sends notices from the queue out over SMS
      * ombqueuehandler.php - sends notices from the queue out over OMB
      * xmppconfirmhandler.php - sends confirmation requests out over XMPP.
      This is in addition to maildaemon.php, which takes incoming messages.
      None of these are "true" daemons -- they don't daemonize themselves
      automatically. Use nohup or another tool to background them. monit can
      also be useful to keep them running.
      At some point, these might become fork()'ing daemons, able to handle
      more than one notice at a time. For now, I'm just running multiple
      instances, hoping they don't interfere.
  17. 13 Aug, 2008 1 commit
  18. 29 Jul, 2008 1 commit
  19. 09 Jul, 2008 1 commit
  20. 07 Jul, 2008 1 commit
  21. 04 Jul, 2008 1 commit
    • Gina Haeussge's avatar
      Validate action parameter · e3e047b2
      Gina Haeussge authored
      Make sure the action request parameter only consists of a-z, A-Z, 0-9, _ or -
      to discourage tampering with the following require_once.
  22. 22 Jun, 2008 1 commit
    • Evan Prodromou's avatar
      remove check immediate · a69dbe7c
      Evan Prodromou authored
      After getting a lot of problems and bugs with this, I'm removing the
      check_immediate code. Instead, I'm going to add this functionality in
      JavaScript. I think that's a preferred practice, anyways.
  23. 19 Jun, 2008 1 commit
  24. 20 May, 2008 1 commit
    • Evan Prodromou's avatar
      trim whitespace · 52600ce0
      Evan Prodromou authored
  25. 19 May, 2008 1 commit
    • Evan Prodromou's avatar
      better headers · 749178f3
      Evan Prodromou authored
      Added H1 headers to all pages. Added H2 headers to sections of pages,
      where appropriate.
      Moved a lot of TODOs around.
      Made the public stream the default if no action is specified.
  26. 17 May, 2008 2 commits