We are no longer offering accounts on this server. Consider https://gitlab.freedesktop.org/ as a place to host projects.

Commit f1c01f9e authored by Brion Vibber's avatar Brion Vibber

Temporary hack until notice_profile_id_idx is updated

to (profile_id, id) instead of (profile_id, created, id).
It's been falling back to PRIMARY instead, which is really
very inefficient for a profile that hasn't posted in a few
months. Even though forcing the index will cause a filesort,
it's usually going to be better. Even for large profiles it
seems much faster than the badly-indexed query.
parent d60c1f1a
......@@ -225,31 +225,62 @@ class Profile extends Memcached_DataObject
{
$notice = new Notice();
$notice->profile_id = $this->id;
// Temporary hack until notice_profile_id_idx is updated
// to (profile_id, id) instead of (profile_id, created, id).
// It's been falling back to PRIMARY instead, which is really
// very inefficient for a profile that hasn't posted in a few
// months. Even though forcing the index will cause a filesort,
// it's usually going to be better.
if (common_config('db', 'type') == 'mysql') {
$index = '';
$query =
"select id from notice force index (notice_profile_id_idx) ".
"where profile_id=" . $notice->escape($this->id);
if ($since_id != 0) {
$query .= " and id > $since_id";
}
$notice->selectAdd();
$notice->selectAdd('id');
if ($max_id != 0) {
$query .= " and id < $max_id";
}
if ($since_id != 0) {
$notice->whereAdd('id > ' . $since_id);
}
$query .= ' order by id DESC';
if ($max_id != 0) {
$notice->whereAdd('id <= ' . $max_id);
}
if (!is_null($offset)) {
$query .= " LIMIT $limit OFFSET $offset";
}
$notice->query($query);
} else {
$index = '';
$notice->orderBy('id DESC');
$notice->profile_id = $this->id;
if (!is_null($offset)) {
$notice->limit($offset, $limit);
$notice->selectAdd();
$notice->selectAdd('id');
if ($since_id != 0) {
$notice->whereAdd('id > ' . $since_id);
}
if ($max_id != 0) {
$notice->whereAdd('id <= ' . $max_id);
}
$notice->orderBy('id DESC');
if (!is_null($offset)) {
$notice->limit($offset, $limit);
}
$notice->find();
}
$ids = array();
if ($notice->find()) {
while ($notice->fetch()) {
$ids[] = $notice->id;
}
while ($notice->fetch()) {
$ids[] = $notice->id;
}
return $ids;
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment