We are no longer offering accounts on this server. Consider https://gitlab.freedesktop.org/ as a place to host projects.

Commit d2e66641 authored by Brion Vibber's avatar Brion Vibber

Validate OStatus avatar URL before fetching.

parent 515cdf28
...@@ -781,8 +781,8 @@ class Ostatus_profile extends Memcached_DataObject ...@@ -781,8 +781,8 @@ class Ostatus_profile extends Memcached_DataObject
} }
/** /**
*
* Download and update given avatar image * Download and update given avatar image
*
* @param string $url * @param string $url
* @throws Exception in various failure cases * @throws Exception in various failure cases
*/ */
...@@ -792,6 +792,9 @@ class Ostatus_profile extends Memcached_DataObject ...@@ -792,6 +792,9 @@ class Ostatus_profile extends Memcached_DataObject
// We've already got this one. // We've already got this one.
return; return;
} }
if (!common_valid_http_url($url)) {
throw new ServerException(_m("Invalid avatar URL %s"), $url);
}
if ($this->isGroup()) { if ($this->isGroup()) {
$self = $this->localGroup(); $self = $this->localGroup();
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment