Commit d289ccb7 authored by mmn's avatar mmn

Minor PHP stylistic features and typing stuff

parent 25e61916
......@@ -120,7 +120,7 @@ class Profile_prefs extends Managed_DataObject
static function getConfigData(Profile $profile, $namespace, $topic) {
try {
$data = self::getData($profile, $namespace, $topic);
} catch (Exception $e) {
} catch (NoResultException $e) {
$data = common_config($namespace, $topic);
}
return $data;
......@@ -160,7 +160,7 @@ class Profile_prefs extends Managed_DataObject
$pref->topic = $topic;
$pref->data = $data;
if (!$pref->insert()) {
if ($pref->insert() === false) {
throw new ServerException('Could not save profile preference.');
}
return true;
......
......@@ -302,7 +302,7 @@ class HTMLOutputter extends XMLOutputter
function hidden($id, $value, $name=null)
{
$this->element('input', array('name' => ($name) ? $name : $id,
$this->element('input', array('name' => $name ?: $id,
'type' => 'hidden',
'id' => $id,
'value' => $value));
......@@ -351,7 +351,7 @@ class HTMLOutputter extends XMLOutputter
{
$this->element('input', array('type' => 'submit',
'id' => $id,
'name' => ($name) ? $name : $id,
'name' => $name ?: $id,
'class' => $cls,
'value' => $label,
'title' => $title));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment