We are no longer offering accounts on this server. Consider https://gitlab.freedesktop.org/ as a place to host projects.

Commit 9ec395b0 authored by Brion Vibber's avatar Brion Vibber

Workaround for reply timeline since_id issue: save the notice.created value...

Workaround for reply timeline since_id issue: save the notice.created value into reply.modified, so we can key off it as expected.

As a hack this removes the mysql_timestamp bit from the field settings on reply.modified so that our value actually gets saved. This *should* work ok as long as system timezone is set correctly, which we now set to UTC to match when connecting.
parent 55b1f3d8
......@@ -1072,6 +1072,7 @@ class Notice extends Memcached_DataObject
$reply->notice_id = $this->id;
$reply->profile_id = $profile->id;
$reply->modified = $this->created;
common_log(LOG_INFO, __METHOD__ . ": saving reply: notice $this->id to profile $profile->id");
......@@ -1132,6 +1133,7 @@ class Notice extends Memcached_DataObject
$reply->notice_id = $this->id;
$reply->profile_id = $mentioned->id;
$reply->modified = $this->created;
$id = $reply->insert();
......
......@@ -502,7 +502,8 @@ uri = U
[reply]
notice_id = 129
profile_id = 129
modified = 384
modified = 142
;modified = 384 ; skipping the mysql_timestamp mode so we can override its setting
replied_id = 1
[reply__keys]
......
......@@ -675,6 +675,7 @@ class TwitterImport
$reply = new Reply();
$reply->notice_id = $notice->id;
$reply->profile_id = $user->id;
$reply->modified = $notice->created;
common_log(LOG_INFO, __METHOD__ . ": saving reply: notice {$notice->id} to profile {$user->id}");
$id = $reply->insert();
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment