We are no longer offering accounts on this server. Consider https://gitlab.freedesktop.org/ as a place to host projects.

Commit 8004e280 authored by Brion Vibber's avatar Brion Vibber

Fix for ticket #2845: singleuser nickname configuration was being overridden...

Fix for ticket #2845: singleuser nickname configuration was being overridden by site owner in router setup.

I've consolidated the checks for which user to use for single-user mode into User::singleUser(), which now uses the configured nickname by preference, falling back to the site owner if it's unset.
This is now called consistently from the places that needed to use the primary user's nickname in routing setup.

Setting $config['singleuser']['nickname'] should now work again as expected.
parent 75ebf3c3
......@@ -1486,7 +1486,8 @@ If an installation has only one user, this can simplify a lot of the
interface. It also makes the user's profile the root URL.
enabled: Whether to run in "single user mode". Default false.
nickname: nickname of the single user.
nickname: nickname of the single user. If no nickname is specified,
the site owner account will be used (if present).
robotstxt
---------
......
......@@ -875,4 +875,33 @@ class User extends Memcached_DataObject
return $owner;
}
/**
* Pull the primary site account to use in single-user mode.
* If a valid user nickname is listed in 'singleuser':'nickname'
* in the config, this will be used; otherwise the site owner
* account is taken by default.
*
* @return User
* @throws ServerException if no valid single user account is present
* @throws ServerException if called when not in single-user mode
*/
static function singleUser()
{
if (common_config('singleuser', 'enabled')) {
$nickname = common_config('singleuser', 'nickname');
if ($nickname) {
$user = User::staticGet('nickname', $nickname);
} else {
$user = User::siteOwner();
}
if ($user) {
return $user;
} else {
throw new ServerException(_("No single user defined for single-user mode."));
}
} else {
throw new ServerException(_('Single-user mode code called when not enabled.'));
}
}
}
......@@ -419,8 +419,9 @@ class Action extends HTMLOutputter // lawsuit
'class' => 'vcard'));
if (Event::handle('StartAddressData', array($this))) {
if (common_config('singleuser', 'enabled')) {
$user = User::singleUser();
$url = common_local_url('showstream',
array('nickname' => common_config('singleuser', 'nickname')));
array('nickname' => $user->nickname));
} else {
$url = common_local_url('public');
}
......
......@@ -701,16 +701,8 @@ class Router
if (common_config('singleuser', 'enabled')) {
$user = User::siteOwner();
if (!empty($user)) {
$nickname = $user->nickname;
} else {
$nickname = common_config('singleuser', 'nickname');
if (empty($nickname)) {
throw new ServerException(_("No single user defined for single-user mode."));
}
}
$user = User::singleUser();
$nickname = $user->nickname;
foreach (array('subscriptions', 'subscribers',
'all', 'foaf', 'xrds',
......
......@@ -974,8 +974,9 @@ function common_tag_link($tag)
$canonical = common_canonical_tag($tag);
if (common_config('singleuser', 'enabled')) {
// regular TagAction isn't set up in 1user mode
$user = User::singleUser();
$url = common_local_url('showstream',
array('nickname' => common_config('singleuser', 'nickname'),
array('nickname' => $user->nickname,
'tag' => $canonical));
} else {
$url = common_local_url('tag', array('tag' => $canonical));
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment