We are no longer offering accounts on this server. Consider https://gitlab.freedesktop.org/ as a place to host projects.

Commit 71820330 authored by Evan Prodromou's avatar Evan Prodromou

Add tags and headers to improve email summary deliverability

SpamAssassin doesn't like HTML email without a) a Mime-Version header
and b) an <html> tag in the body. Although not everyone uses SA, there
are probably other spam systems that implement similar rules. And it's
always nice to play nice.
parent 0f53c07f
......@@ -120,8 +120,16 @@ class UserEmailSummaryHandler extends QueueHandler
$new_top = $notice->_items[0]->id;
}
// TRANS: Subject for e-mail.
$subject = sprintf(_m('Your latest updates from %s'), common_config('site', 'name'));
$out = new XMLStringer(true);
$out->elementStart('html');
$out->elementStart('head');
$out->element('title', null, $subject);
$out->elementEnd('head');
$out->elementStart('body');
$out->elementStart('div', array('width' => '100%',
'style' => 'background-color: #ffffff; border: 4px solid #4c609a; padding: 10px;'));
......@@ -201,19 +209,18 @@ class UserEmailSummaryHandler extends QueueHandler
common_config('site', 'name'))."</p>");
$out->elementEnd('div');
$out->elementEnd('body');
$out->elementEnd('html');
$body = $out->getString();
// FIXME: do something for people who don't like HTML email
$subject = sprintf(_m('Your latest updates from %s'), common_config('site', 'name'));
// TRANS: Subject for e-mail.
mail_to_user($user,
$subject,
$body,
array('Content-Type' => 'text/html; charset=UTF-8'));
array('Content-Type' => 'text/html; charset=utf-8',
'Mime-Version' => '1.0'));
if (empty($ess)) {
$ess = new Email_summary_status();
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment