Commit 58d798b6 authored by Evan Prodromou's avatar Evan Prodromou

Change NoticeList::prefill() to a static function

parent 06e24225
......@@ -87,7 +87,7 @@ class NoticeList extends Widget
$total = count($notices);
$notices = array_slice($notices, 0, NOTICES_PER_PAGE);
$this->prefill($notices);
self::prefill($notices);
foreach ($notices as $notice) {
......@@ -122,10 +122,23 @@ class NoticeList extends Widget
return new NoticeListItem($notice, $this->out);
}
function prefill(&$notices)
static function prefill(&$notices, $avatarSize=AVATAR_STREAM_SIZE)
{
// Prefill the profiles
$profiles = Notice::fillProfiles($notices);
Profile::fillAvatars($profiles, AVATAR_STREAM_SIZE);
// Prefill the avatars
Profile::fillAvatars($profiles, $avatarSize);
$p = Profile::current();
$ids = array();
foreach ($notices as $notice) {
$ids[] = $notice->id;
}
if (!empty($p)) {
Memcached_DataObject::pivotGet('Fave', 'notice_id', $ids, array('user_id' => $p->id));
}
}
}
......@@ -80,7 +80,7 @@ class ThreadedNoticeList extends NoticeList
$total = count($notices);
$notices = array_slice($notices, 0, NOTICES_PER_PAGE);
$this->prefill($notices);
self::prefill($notices);
$conversations = array();
......@@ -224,8 +224,7 @@ class ThreadedNoticeListItem extends NoticeListItem
$item = new ThreadedNoticeListMoreItem($moreCutoff, $this->out, count($notices));
$item->show();
}
// XXX: replicating NoticeList::prefill(), annoyingly
$this->prefill($notices);
NoticeList::prefill($notices, AVATAR_MINI_SIZE);
foreach (array_reverse($notices) as $notice) {
if (Event::handle('StartShowThreadedNoticeSub', array($this, $this->notice, $notice))) {
$item = new ThreadedNoticeListSubItem($notice, $this->notice, $this->out);
......@@ -250,13 +249,6 @@ class ThreadedNoticeListItem extends NoticeListItem
parent::showEnd();
}
function prefill(&$notices)
{
// Prefill the profiles
$profiles = Notice::fillProfiles($notices);
Profile::fillAvatars($profiles, AVATAR_MINI_SIZE);
}
}
// @todo FIXME: needs documentation.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment