We are no longer offering accounts on this server. Consider https://gitlab.freedesktop.org/ as a place to host projects.

Commit 5592333b authored by Brion Vibber's avatar Brion Vibber

Fix for ticket #2168: if we've already flagged a profile from another window,...

Fix for ticket #2168: if we've already flagged a profile from another window, let the 'Flag' form submission gracefully show the updated state instead of throwing an error (error message isn't even exposed properly in AJAX submissions)
parent 607d9589
......@@ -60,13 +60,6 @@ class FlagprofileAction extends ProfileFormAction
assert(!empty($user)); // checked above
assert(!empty($this->profile)); // checked above
if (User_flag_profile::exists($this->profile->id,
$user->id)) {
// TRANS: Client error when setting flag that has already been set for a profile.
$this->clientError(_m('Flag already exists.'));
return false;
}
return true;
}
......@@ -104,7 +97,13 @@ class FlagprofileAction extends ProfileFormAction
// throws an exception on error
User_flag_profile::create($user->id, $this->profile->id);
if (User_flag_profile::exists($this->profile->id,
$user->id)) {
// We'll return to the profile page (or return the updated AJAX form)
// showing the current state, so no harm done.
} else {
User_flag_profile::create($user->id, $this->profile->id);
}
if ($this->boolean('ajax')) {
$this->ajaxResults();
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment