We are no longer offering accounts on this server. Consider https://gitlab.freedesktop.org/ as a place to host projects.

Commit 2a29738d authored by Brion Vibber's avatar Brion Vibber

Revert "Session GC fix: save session.modified field as UTC so our comparisons...

Revert "Session GC fix: save session.modified field as UTC so our comparisons work." - no longer needed with ticket #3020 fix to time zone settings

This reverts commit a7abb232.
parent 47f31bce
......@@ -87,7 +87,6 @@ class Session extends Memcached_DataObject
$session->id = $id;
$session->session_data = $session_data;
$session->created = common_sql_now();
$session->modified = common_sql_now();
$result = $session->insert();
......@@ -109,7 +108,6 @@ class Session extends Memcached_DataObject
$orig = clone($session);
$session->session_data = $session_data;
$session->modified = common_sql_now();
$result = $session->update($orig);
......
......@@ -513,20 +513,7 @@ profile_id = K
id = 130
session_data = 34
created = 142
modified = 142
; Warning: using DB_DATAOBJECT_MYSQLTIMESTAMP (256) causes DB_DataObject
; to SILENTLY REMOVE ATTEMPTS TO SET THIS FIELD DIRECTLY, which is pretty
; bad because the default behavior for auto-updated TIMESTAMP fields is
; to use local time. Local time can't be compared to UTC in any useful
; way, so doing that breaks session GC.
;
; Instead we'll use the plain datetime settings so it'll actually save the
; UTC value we provide when updating.
;
; Long-term fix: punch MySQL in the face until it understands that local
; time is a tool of the cyber-devil.
;
;modified = 384
modified = 384
[session__keys]
id = K
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment